search

diderot-edu / diderot-feedback

0 stars 0 forks source link

Scrollbars appear when grading code on Windows #67

Closed ishantheperson closed 4 years ago

ishantheperson commented 4 years ago

Each line of code has its own scrollbar which is quite distracting when trying to grade code for cost bounds.

It seems to happen because .code-viewer code has overflow: scroll set when it should be just overflow-x: auto (better yet: supply 1 scrollbar for the entire code viewer)

image

umutacar commented 4 years ago

Hopefully fixed. We don't have access to windows+edge unfortunately

ishantheperson commented 4 years ago

You can use Virtual Andrew to get access to windows (this happened across all browsers)

https://www.cmu.edu/computing/services/endpoint/software/virtual-andrew.html

I haven't verified the issue is resolved yet but will close this issue once I hop on my windows machine

ishantheperson commented 4 years ago

Unfortunately doesn't appear to be resolved: image

kopecs commented 4 years ago

This is also reproducible on Linux (tested with firefox 81). It looks like .submission-details code has overflow: scroll; changing to auto removes the scrollbars.

umutacar commented 4 years ago

should be fixed.