search

diderot-edu / diderot-feedback

0 stars 0 forks source link

Floating point error when assigning grades #68

Closed ishantheperson closed 4 years ago

ishantheperson commented 4 years ago

This looks quite unprofessional. I would recommend representing grades as integers and representing the values internally as scaled by 100x or something

image

umutacar commented 4 years ago

Frontend is using rounding now (recent deployment). Like the idea of scaling. This would be a bigger change but will keep this in mind.

ishantheperson commented 4 years ago

Sounds good, rounding is probably "good enough" but it does feel like a "band aid" fix.