didi / booster

🚀Optimizer for mobile applications
https://booster.johnsonlee.io
Apache License 2.0
4.83k stars 576 forks source link

增量编译时对 jar 处理的问题 #406

Closed woyelaishishiba closed 1 year ago

woyelaishishiba commented 1 year ago

com.didiglobal.booster.gradle.BoosterTransformInvocation 中的 doIncrementalTransform(jarInput: JarInput) 在对增量编译的 jar 处理时删除了 jarInput,我理解删除的应该是 jar 的 output,否则升级 jar 后增量编译时会出现类冲突的问题。

预期将 jarInput.status == REMOVED 的处理从 jarInput.file.delete() 修改为

outputProvider?.let { provider ->
    provider.getContentLocation(
        jarInput.id, jarInput.contentTypes, jarInput.scopes, Format.JAR
    )?.takeIf { it.exists() }?.delete()
}
johnsonlee commented 1 year ago

直接提个 PR ?

johnsonlee commented 1 year ago

released in v4.16.0-alpha2