Remove pool and or - Githubissues

didi / gendry

a golang library for sql builder

Apache License 2.0

1.62k stars 195 forks source link

Remove pool and or #78

Closed Colstuwjx closed 4 years ago

Colstuwjx commented 4 years ago

This PR carried remove pool thing, and to prove that remove pool with _or operator works well.

Colstuwjx commented 4 years ago

This PR is ONLY for demo, DO NOT MERGE.

caibirdme commented 4 years ago

I think this change is great, but I will remove the sync.Pool first, and then merge your pr. And I've benchmarked the change, the performance isn't affected actually

Colstuwjx commented 4 years ago

Sure, pls do!

caibirdme commented 4 years ago

Sure, pls do!

I've already merged that pr, pls update your own, and make sure it can pass all the test cases.

Colstuwjx commented 4 years ago

I'll update the original one, this PR is just for demo usage :)

Colstuwjx commented 4 years ago

Close since #77 complete!