didibus / anakondo

Minor mode for Clojure[Script] completion powered by clj-kondo.
MIT License
114 stars 1 forks source link

Add support for project.el #5

Closed manuel-uberti closed 3 years ago

manuel-uberti commented 3 years ago

Hi,

first of all thank you for this package.

Would it be possible to support project.el as well as projectile? You could get the project root with project.el as well, and maybe have projectile as an optional dependency.

What do you think?

didibus commented 3 years ago

Yes I've been thinking about this myself. I always found it hard to find information about project.el though, and couldn't easily tell which version of Emacs has it and with what features.

But I think now that more people are on 27.1, it might start to gain more traction. If I have time I'll investigate making the switch to it as the default project manager, and have projectile as a backup.

manuel-uberti commented 3 years ago

Thank you. Feel free to close this, then. I just wanted to raise awareness of project.el. :)

manuel-uberti commented 3 years ago

Oh, FTR, project.el is on ELPA if you want to check out a recent version: here.

andreyorst commented 3 years ago

I've submitted the possible fix, but I was also thinking if project root should be buffer-locally cached? Projects change root rarely, and getting project root in each function may seem expensive and repeated work for no particular reason unless I'm missing something.