Peer review

[standrd]

Repository

• Concept: it would be nice to see an image or small animation of the interactive datavisualisation in the README. If that's not possible yet, I would make the explanation of the concept a bit more detailed.
• Link to example: I dont' see a link to a used example, if you simply used the D3 docs to build what you did, referring to this would be enough I think.
• Sketch: since there is not image of the final product yet, you might want to upload the sketch of the final product here as a visualisation.
• Data: what is done with invalid and empty values? This does not yet become clear from the data explanation.
• Plagiarism and acknowledgements: I might be wrong, but I assume you might have used more sources to gather some knowledge or data. Even if it's just a bit, linking to it will only make the research/project more legitimate.

Wiki

• Data cleaning: the part about data cleaning currently only contains helper functions I assume, but not the actual process of cleaning your final data.
• Data object before & after: there is no example of what the data looks like before or after.
• Update pattern: there is no update pattern documented in the wiki yet. Documentation on the D3 part is not enough as a whole I think.
• Learned topics: I would dedicate a page in your wiki to new topics you learned during the process of data cleaning, transforming and D3. This is currently missing.

Live demo

I can see where it's going, and from the sketch in your wiki it's clear what you're going to make. The live demo itself however wouldn't show this to me right now as a new user looking at it. It will require better labeling and data updating dynamically, but I assume this is something you still need to get to.

[standrd]

Code

• It might be personal preference, but if I would enter a single url in the getData() function, I would prefer it not being wrapped in an array https://github.com/didiercatz/frontend-data/blob/2ce8e08b10a3533192553185a683370433fe14f8/src/modules/utils.js#L85-L88 Personally I would add some handling for that, but it might also make it less readable at first.
• In your getData function you could also append the limit automatically for opendata.rdw.nl endpoints https://github.com/didiercatz/frontend-data/blob/2ce8e08b10a3533192553185a683370433fe14f8/src/modules/constants.js#L1-L3
• Although I never used Svelte, from your project it looks easy to read and understand.

[didier]

Thanks for the feedback! I've intentionally used an array within getData, as I want to be able to fetch data from multiple data sources, because I want to destructure them into their own variables for cleanup, but only if all the data successfully loads. See line 87 with the Promise.all. I could abstract what happens in the map into its own function, but I don't think that would benefit me — it's only being used inside getData anyway. https://github.com/didiercatz/frontend-data/blob/2ce8e08b10a3533192553185a683370433fe14f8/src/modules/data.js#L12-L20