Linux build header warnings (trunk rev 2705)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. compile a using application with g++ version 4.7.2 with the following flags:

  -Wfloat-equal
  -Wshadow
  -Wunused-parameter
  -Wunused-variable

What is the expected output? 

  A build with no warnings.

What do you see instead?

  See attached build log:

What version of the product are you using? 

  trunk revision 2705

On what operating system?

  Debian 7.1, amd64

Please provide any additional information below.

Original issue reported on code.google.com by tom.brow...@gmail.com on 24 Oct 2013 at 8:01

Attachments:

• build.log

[GoogleCodeExporter]

Thanks for sharing, hopefully we can fix the warning for the next release.

Original comment by erwin.coumans on 24 Oct 2013 at 8:16

[GoogleCodeExporter]

Thanks, Erwin.  Would patches help?

Original comment by tom.brow...@gmail.com on 25 Oct 2013 at 12:13

[GoogleCodeExporter]

Sure, a patch is welcome. Note that a warning patch cannot contain any new 
functionality (new features or bug fixes should be in a separate patch)

Original comment by erwin.coumans on 25 Oct 2013 at 12:18

[GoogleCodeExporter]

Note that there are two main classes of warnings: (1) comparing float values 
for equality and (2) local variables shadowing a member of this.

Questions: 

(1) Do you have a macro or function that uses some desired difference to 
determine float equality?  If not I have a set of C++ functions from Professor 
Donald Knuth that will do the trick.

(2) I assume the local variables are just that so there is no intent to change 
the this member of the same name.  Is that assumption correct? 

Original comment by tom.brow...@gmail.com on 25 Oct 2013 at 12:25

[GoogleCodeExporter]

moved to https://github.com/bulletphysics/bullet3/issues/83

Original comment by erwin.coumans on 30 Mar 2014 at 5:49

• Changed state: Done