didil / sidekiq-client-cli

Command line client for Sidekiq
MIT License
18 stars 18 forks source link

Update to Sidekiq 3.x #13

Closed calveto closed 10 years ago

calveto commented 10 years ago

@didil

All of the specs pass with this change. Do you know anything else that would need to be done for this to work with Sidekiq 3.x?

I did an integration test in my environment and was able to push a job into a queue and the job complete successfully.

This should resolve https://github.com/didil/sidekiq-client-cli/issues/12

didil commented 10 years ago

mm this forces using sidekiq 3.0+ , I don't really want to do that , maybe just replacing

"~> 2.15" with ">= 2.15" would do ?

I'm not aware of the breaking changes in sidekiq 3.0 that could affect the gem

didil commented 10 years ago

fixed in 3c85f524f7baf2496ba1f28cfc1571239f4492c2

calveto commented 10 years ago

Thanks :thumbsup: