didil / sidekiq-client-cli

Command line client for Sidekiq
MIT License
18 stars 18 forks source link

Add a retry option #4

Closed codebender closed 11 years ago

codebender commented 11 years ago

Hi @didil,

So I consolidated my previous attempt (#3) to one option:

-retry false or -r false - Tells Sidekiq to not retry the job, if the job fails -retry 5 or -r 5 - Tells Sidekiq to retry the job at most 5 times, if the job fails

This now mimics the options of sidekiq's advanced options (https://github.com/mperham/sidekiq/wiki/Advanced-Options#workers)

coveralls commented 11 years ago

Coverage Status

Coverage remained the same when pulling ba5f6d0f4b910e62c37da96d42aad3bf77ffe04d on MisterBender:feature/add_retry_arg into 01b343c59a2e0a45e9fd147001169841f1fdd2cd on didil:master.

didil commented 11 years ago

Thanks but we've had to modify the way the default options are handled due to a breaking change in sidekiq 2.15.0 so that conflicts with your pull request, please have a look at the current master, pull it, make the changes and send a new pull request, it should be quick