Fix default queue parsing for sidekiq 2.15.0

didil / sidekiq-client-cli

Command line client for Sidekiq

MIT License

18 stars 18 forks source link

Fix default queue parsing for sidekiq 2.15.0 #6

Closed Saicheg closed 11 years ago

Saicheg commented 11 years ago

Since sidekiq changed the way how they load default params now sidekiq-client is broken.

coveralls commented 11 years ago

Coverage remained the same when pulling 354311222369bd800517bbfca4f034f0e745cef3 on Saicheg:master into 01b343c59a2e0a45e9fd147001169841f1fdd2cd on didil:master.

didil commented 11 years ago

great, just merged, thanks

codebender commented 11 years ago

@didil maybe the DEFAULT_QUEUE should exist? using the new Sidekiq.default_worker_options https://github.com/mperham/sidekiq/commit/6bb6d09da4753d44117430f4e4754a845cb1bc0a

Saicheg commented 11 years ago

@MisterBender it's impossible to know now which queue is default until you load config file. and we are loading it after parsing user input

codebender commented 11 years ago

@Saicheg oops I missed the change here: https://github.com/didil/sidekiq-client-cli/pull/6/files#diff-d7047a488f0160a1cf5693eba1274e2aR31

I'll follow this style for my PR