fix gemspec compability

didil / sidekiq-client-cli

Command line client for Sidekiq

MIT License

18 stars 18 forks source link

fix gemspec compability #8

Closed Saicheg closed 10 years ago

Saicheg commented 10 years ago

Sidekiq 2.16.0 was released 2 weeks ago....

coveralls commented 10 years ago

Coverage remained the same when pulling 7ebf64b35b0e8762d934bdc3f80127d6000971cb on Saicheg:master into 92070d12682de50a53be49aac541a43c007ee66d on didil:master.

didil commented 10 years ago

any reason why we should remove compatibility with 2.15.0 ?

bnix commented 10 years ago

Unless there are breaking changes in sidekiq beyond 2.15.x, I think the sidekiq version specification should be changed to >= 2.15.0 instead of ~> 2.15.0. Anyone trying to use sidekiq-client-cli with sidekiq 2.16+ gets a dependency notice about sidekiq 2.15 not being available despite the read me stating the gem works with sidekiq >= 2.15.0. I was able to get my bundle working again with this commit.

didil commented 10 years ago

Fixed in this commit https://github.com/didil/sidekiq-client-cli/commit/f33f9fde44b0c32bea11ae18b1f158f4f0ab47ab