search

didomi / react-native

Didomi SDK for React Native
Other
9 stars 2 forks source link

Handle new event listeners #39

Closed Minishlink closed 2 years ago

Minishlink commented 2 years ago

When calling onReady, a warn log is issued: EventEmitter.removeListener('on_ready_callback', ...): Method has been deprecated. Please instead use remove() on the subscription returned by EventEmitter.addListener. Not critical but it adds noise during development

felipe-saez commented 2 years ago

Hello Louis,

Apologies for not replying earlier.

Thanks for creating this ticket. We'll look into it.

Kind regards,

Felipe

nicolas-chaix-didomi commented 2 years ago

Hello Louis,

Unfortunately, we won't be able to use the new event listener since it would require to use a React-Native version (0.65) not compatible with android API 16.

Regards

Minishlink commented 2 years ago

Hello,

Ok, I'd keep this open though, because EventEmitter.removeListener is deprecated and will be removed in a future React Native version.

OmedMilat commented 1 year ago

This is a problem now, removeListener is removed since RN 0.69.0: https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v0690