🦺 🩹 Aca-py V1 update cleanup

cl0ete commented 2 months ago

Address some issues found in v1 update

github-actions[bot] commented 2 months ago

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
issuer.py	186	2	99%	670–671
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	148	33	78%	95–97, 102, 162–164, 169, 245, 253–255, 260, 304–309, 315–317, 383–385, 391, 430–432, 437, 473–475, 517–519
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	172	35	80%	118–160, 201–205, 372–376, 415–420, 453–457, 485–490, 539–540
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 201–202
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 223–224, 251
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_connections.py	131	2	98%	280–281
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	31	1	97%	130
test_tenants.py	403	15	96%	203, 247–248, 287, 788, 832–833, 842–843, 852–853, 865–866, 875–876
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	71	10	86%	102–117
app/tests/e2e/issuer
test_get_records_paginated.py	42	2	95%	63–64
test_save_exchange_record.py	75	1	99%	181
app/tests/e2e/verifier
test_get_records_paginated.py	42	2	95%	59–60
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	236	12	95%	691–762
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	149	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	347–351
app/tests/util
connections.py	87	29	67%	104–129, 138–155, 172–181, 236–256
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	56	5	91%	20, 79–82, 105, 129
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	8	56%	17–33
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	31–32
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	193	32	83%	98, 161–171, 194–208, 222, 229–235, 261, 289–290, 318–322, 335–339, 364–377
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	234	36	85%	155, 157–170, 208–218, 251–252, 265–279, 334–338, 344–347, 349–352, 377–378, 421–423, 457, 468–469
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_acapy_events_processor.py	161	2	99%	168–171
test_sse_manager.py	179	3	98%	214–215, 221
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	14991	928	94%

Tests	Skipped	Failures	Errors	Time
1078	4 :zzz:	0 :x:	0 :fire:	4m 32s :stopwatch:

github-actions[bot] commented 2 months ago

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
issuer.py	186	2	99%	670–671
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	148	33	78%	95–97, 102, 162–164, 169, 245, 253–255, 260, 304–309, 315–317, 383–385, 391, 430–432, 437, 473–475, 517–519
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
revocation_registry.py	172	46	73%	118–160, 201–205, 372–376, 415–420, 453–457, 475–490, 496–505, 539–540
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 201–202
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 223–224, 251
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_connections.py	131	2	98%	280–281
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	31	1	97%	130
test_revocation.py	111	73	34%	27–77, 90–107, 118–144, 156–181, 193–207, 219–256, 267–293, 305–335, 346–349
test_tenants.py	403	346	14%	29–73, 84–117, 128–172, 185–254, 265–316, 329–458, 467–519, 528–564, 573–622, 631–680, 691–733, 745–794, 805–876, 885–954
test_wallet_dids.py	71	15	79%	102–117, 129–140
app/tests/e2e/issuer
test_get_records_paginated.py	42	31	26%	24–119
test_save_exchange_record.py	75	1	99%	181
app/tests/e2e/verifier
test_get_records_paginated.py	42	29	31%	26–113
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	149	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	347–351
app/tests/util
connections.py	87	19	78%	154–155, 169, 181, 191–223, 251–256
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	56	5	91%	20, 79–82, 105, 129
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	18–36
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	193	32	83%	98, 161–171, 194–208, 222, 229–235, 261, 289–290, 318–322, 335–339, 364–377
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	234	36	85%	155, 157–170, 208–218, 251–252, 265–279, 334–338, 344–347, 349–352, 377–378, 421–423, 457, 468–469
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_acapy_events_processor.py	161	2	99%	168–171
test_sse_manager.py	179	3	98%	214–215, 221
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	14991	1499	90%

Tests	Skipped	Failures	Errors	Time
1078	38 :zzz:	0 :x:	0 :fire:	6m 6s :stopwatch:

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
issuer.py	185	2	99%	670–671
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	148	33	78%	95–97, 102, 162–164, 169, 245, 253–255, 260, 304–309, 315–317, 383–385, 391, 430–432, 437, 473–475, 517–519
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	172	35	80%	118–160, 201–205, 372–376, 415–420, 453–457, 485–490, 539–540
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 201–202
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 223–224, 251
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_connections.py	131	2	98%	280–281
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	31	1	97%	130
test_tenants.py	403	15	96%	203, 247–248, 287, 788, 832–833, 842–843, 852–853, 865–866, 875–876
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	71	10	86%	102–117
app/tests/e2e/issuer
test_get_records_paginated.py	42	2	95%	63–64
test_save_exchange_record.py	75	1	99%	181
app/tests/e2e/verifier
test_get_records_paginated.py	42	2	95%	59–60
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	236	12	95%	691–762
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	149	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	347–351
app/tests/util
connections.py	87	29	67%	104–129, 138–155, 172–181, 236–256
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	56	5	91%	20, 79–82, 105, 129
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	8	56%	17–33
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	31–32
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	193	32	83%	98, 161–171, 194–208, 222, 229–235, 261, 289–290, 318–322, 335–339, 364–377
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	234	36	85%	155, 157–170, 208–218, 251–252, 265–279, 334–338, 344–347, 349–352, 377–378, 421–423, 457, 468–469
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_acapy_events_processor.py	161	2	99%	168–171
test_sse_manager.py	179	3	98%	214–215, 221
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	14990	928	94%

Tests	Skipped	Failures	Errors	Time
1078	4 :zzz:	0 :x:	0 :fire:	4m 29s :stopwatch:

github-actions[bot] commented 2 months ago

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
issuer.py	185	2	99%	670–671
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	148	33	78%	95–97, 102, 162–164, 169, 245, 253–255, 260, 304–309, 315–317, 383–385, 391, 430–432, 437, 473–475, 517–519
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
revocation_registry.py	172	46	73%	118–160, 201–205, 372–376, 415–420, 453–457, 475–490, 496–505, 539–540
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 201–202
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 223–224, 251
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_connections.py	131	2	98%	280–281
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	31	1	97%	130
test_revocation.py	111	73	34%	27–77, 90–107, 118–144, 156–181, 193–207, 219–256, 267–293, 305–335, 346–349
test_tenants.py	403	346	14%	29–73, 84–117, 128–172, 185–254, 265–316, 329–458, 467–519, 528–564, 573–622, 631–680, 691–733, 745–794, 805–876, 885–954
test_wallet_dids.py	71	15	79%	102–117, 129–140
app/tests/e2e/issuer
test_get_records_paginated.py	42	31	26%	24–119
test_save_exchange_record.py	75	1	99%	181
app/tests/e2e/verifier
test_get_records_paginated.py	42	29	31%	26–113
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	149	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	347–351
app/tests/util
connections.py	87	19	78%	154–155, 169, 181, 191–223, 251–256
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	56	5	91%	20, 79–82, 105, 129
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	18–36
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	193	32	83%	98, 161–171, 194–208, 222, 229–235, 261, 289–290, 318–322, 335–339, 364–377
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	234	36	85%	155, 157–170, 208–218, 251–252, 265–279, 334–338, 344–347, 349–352, 377–378, 421–423, 457, 468–469
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_acapy_events_processor.py	161	2	99%	168–171
test_sse_manager.py	179	3	98%	214–215, 221
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	14990	1499	90%

Tests	Skipped	Failures	Errors	Time
1078	38 :zzz:	0 :x:	0 :fire:	6m 4s :stopwatch:

didx-xyz / aries-cloudapi-python

🦺 🩹 Aca-py V1 update cleanup #1000

Quality Gate passed