didx-xyz / aries-cloudapi-python

Apache License 2.0
12 stars 8 forks source link

🧪 Review and enhance revocation tests #481

Open wdbasson opened 1 year ago

wdbasson commented 1 year ago

Replicate demo test case: https://aca-py.org/main/demo/#revocation

ff137 commented 12 months ago

Currently we can create credential definitions that support revocation, and the issuer can call /revoke-credential after a credential has been issued. This is asserted in the tests.

One enhancement would be to assert the behavior during a proof request, after a cred has been revoked. And other things, like asserting that a non-revocable credential should error when attempted to revoke ...

ff137 commented 12 months ago

Apart from credentials, there's some revocation registry behavior that is only mocked, but not e2e tested.

Here's a summary of RevocationAPI functions, and whether it's covered or not: :white_check_mark: used and covered by tests:

:x: Unused methods:

So, there you have it! Revocation is fairly complex and we should work towards implementing more of those unused methods in order to support it properly.

edit: added checkboxes for the methods that have since been implemented