feat: improved error handling

didx-xyz / ssi-trust-registry

Trust Registry for Self-Sovereign Identity Ecosystems

Apache License 2.0

6 stars 2 forks source link

feat: improved error handling #197

Closed niall-shaw closed 8 months ago

niall-shaw commented 8 months ago

Both frontend and backend improvements.

Revert record changes if an error occurs (i.e. submission approval / rejection, entity update / creation, invitation creation).
- Specifically addressing the use case of an erroneous third party service, i.e. email client.
UI for 500 errors

As well as other code refactors / minor fixes.

https://github.com/didx-xyz/ssi-trust-registry/assets/100220424/8ec5d2e6-1888-4b70-ac12-9759471c3080

Video above shows UI when server error occurs during submitting of form.

niall-shaw commented 8 months ago

Note: I looked into MongoDB transactions as a preliminary idea (see https://github.com/didx-xyz/ssi-trust-registry/pull/197/commits/de7296671114dea25fb548d7b1d63cbc1dd24cae), but the setup of replica sets seems quite difficult via docker compose for testing. Also, a lot of research seems to indicate 'if you can implement the solution without using transactions, you should', so I'm trying to KISS ;)

niall-shaw commented 8 months ago

However, supposedly replica sets should be necessary in production environments, so perhaps we should update docker to include replica sets regardless of whether we use transactions or not.

niall-shaw commented 8 months ago

Closing in favour of #198