search

didymo / OnkoDICOM

OnkoDICOM was created with Radiation Oncologists to allow Radiation Oncologists to do research on DICOM standard image sets (DICOM-RT, CT, MRI, PET) using open source technologies, such as pydicom, dicompyler-core, PySide6, PIL, and matplotlib. OnkoDICOM is cross platform, open source software, and welcomes contributions. OnkoDICOM was inspired by dicompyler.
https://onkodicom.com.au
GNU Lesser General Public License v2.1
60 stars 41 forks source link

Cache test file #269

Closed celeron533 closed 1 year ago

celeron533 commented 1 year ago

Cache the test file (DICOM-RT-02.zip). This saves at least 3 minutes (sometimes 5 minutes) for each build.

Note: pip is not cached if we always want to use the latest version of packages

didymo commented 1 year ago

This PR appears to be using python3.9, is this interpretation correct? Is OnkoDICOM not using python3.10 at the moment?

celeron533 commented 1 year ago

This PR appears to be using python3.9, is this interpretation correct? Is OnkoDICOM not using python3.10 at the moment?

Hi Ashley, As far as I know, both the wiki page and github action are using Python 3.9 https://github.com/didymo/OnkoDICOM/wiki/Installation-Instructions

Running on Python 3.10 need some adjustments, especially lock the dependicies in requirements.txt

celeron533 commented 1 year ago

I can create a build matrix to build and test on both Python 3.9 and 3.10

celeron533 commented 1 year ago

I can create a build matrix to build and test on both Python 3.9 and 3.10

of course, in another PR

sjswerdloff commented 1 year ago

I can create a build matrix to build and test on both Python 3.9 and 3.10

of course, in another PR

That would be great. But make the 3.10 optional in terms of passing. We may have problems being compatible with both 3.9 and 3.10 and I want to start with what we know should work. We will probably have to pin packages in the 3.10 build and I would like to try to have both 3.9 and 3.10