didymo / OnkoDICOM

OnkoDICOM was created with Radiation Oncologists to allow Radiation Oncologists to do research on DICOM standard image sets (DICOM-RT, CT, MRI, PET) using open source technologies, such as pydicom, dicompyler-core, PySide6, PIL, and matplotlib. OnkoDICOM is cross platform, open source software, and welcomes contributions. OnkoDICOM was inspired by dicompyler.
https://onkodicom.com.au
GNU Lesser General Public License v2.1
62 stars 42 forks source link

Move everything to Poetry #275

Closed celeron533 closed 1 year ago

celeron533 commented 1 year ago
didymo commented 1 year ago

Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update] to fix it.

sjswerdloff commented 1 year ago

the poetry.lock file contents will depend on which version of Python is in use, and potentially on which platform. We might want to introduce a matrix of poetry.lock files and tell the user that they need to move the appropriate one in to place.

celeron533 commented 1 year ago

Hi @sjswerdloff there are some discussions about this topic. https://github.com/python-poetry/poetry/issues/2560#issuecomment-644249484

And can define the python restricted dependencies: https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies

Sample

[tool.poetry.group.dependencies]
foo = {version = "12", python = "3.9", markers = "sys_platform == 'win32'"}
foo = {version = "13", python = "3.9", markers = "sys_platform == 'darwin'"}
foo = {version = "13", python = "3.10", markers = "sys_platform == 'win32'"}
foo = {version = "14", python = "3.10", markers = "sys_platform == 'darwin'"}
sjswerdloff commented 1 year ago

Hi @sjswerdloff there are some discussions about this topic. https://github.com/python-poetry/poetry/issues/2560#issuecomment-644249484

And can define the python restricted dependencies: https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies

Sample

[tool.poetry.group.dependencies]
foo = {version = "12", python = "3.9", markers = "sys_platform == 'win32'"}
foo = {version = "13", python = "3.9", markers = "sys_platform == 'darwin'"}
foo = {version = "13", python = "3.10", markers = "sys_platform == 'win32'"}
foo = {version = "14", python = "3.10", markers = "sys_platform == 'darwin'"}

This would be an appropriate PR