Closed markusguenther closed 2 years ago
Hey @markusguenther,
thanks for your great enhancement of the DB-Storage. Could you please have a look at my changes made to the way how values are transformed to strings for the output (new method getStringValue
) and update the PR accordingly? This would be awesome. Then i can hopefully merge your PR soon.
This will possibly fix #7.
Hello @Benjamin-K
This patch was originally from Andy Meier. I did not find the PR or issue here but wanted to give this back.
I just needed to adapt the composer patch in the project while updating the package. If you say this is already fixed. I can also close the PR :) Just want to prevent that the change gets lost.
TBH don't know where the change was submitted before.
Author: Andy Meier <andy.meier@visol.ch>
Date: Wed Mar 13 10:20:27 2019 +0100
Hi @markusguenther Please abandon this PR; we'll provide a more mature one.