search

diederich / moneymoney-monzo

Extension for MoneyMoney.app to query data from Monzo UK
MIT License
2 stars 1 forks source link

Allow for configurable Monzo Client ID & Secret via MoneyMoney credentials #2

Closed gdelmas closed 5 years ago

gdelmas commented 5 years ago

As the Monzo Client ID is only valid for a small set of users and basically has to be set up per person it should be configurable via MoneyMoney's credentials.

This change required to remove the email address from the account details. Instead the actual account number and bank sort code will be used. While changing this I also added support for Monzo's joint accounts.

When a user adds a Monzo account for the first time he will have to provide the following values in MoneyMoney:

This will require a change from @mrh-line, as currently only a Email field is shown when setting Monzo credentials. @mrh-line might also be able to set the field names accordingly.

To test the proposed changes you will need to change the BANK_CODE in line 32 to something like Monzo Test. This way MoneyMoney will show a Username and Password before opening the OAuth browser window.

mrh-line commented 5 years ago

@gdelmas Thank you. I’ve changed the labels and input fields in MoneyMoney accordingly. The updated bank server settings will take effect within the next few hours. (The labels might not be proper localised to German/English yet, but that will be fixed in the next regular update of MoneyMoney.)

diederich commented 5 years ago

@mrh-line - Just saw the update, downloaded and works like a charm! 🙏

gdelmas commented 5 years ago

@mrh-line oh wow, that was fast, as always. how does the update to the credentials fields work? is this a file that configuration read by MoneyMoney over the web?

i guess the version published on the extensions page would need an update as well.

@diederich thanks for adding these changes, much appreciated.

mrh-line commented 5 years ago

@gdelmas Yes, it’s a configuration file downloaded by MoneyMoney from the web. In the log window this action will be logged as »Requesting latest bank server settings«. I’ve signed and updated the extension on https://moneymoney-app.com/extensions/.