diefarbe / node-lib

A node library for manipulating color on the Das Keyboard 5Q
MIT License
57 stars 8 forks source link

Feature Complete checklist #1

Open sebirdman opened 6 years ago

sebirdman commented 6 years ago

What do we need to do for the lib to be "feature complete"?

Here's a high level list I've got:

Ideally one day we can also handle:

mikejr83 commented 6 years ago

This being a library I just want to make sure we have clarity on the profile stuff:

If profiles are stored somewhere in the keyboard firmware then it would make sense for the lib to read/write/activate them. However if they're more of a software defined thing then we should approach the library from the aspect of creating a structure for defining a profile and submitting it to the keyboard.

I'm thinking from our discussions so far that profiles are more of a software definition than what is stored in the keyboard itself (I'd like to be proven wrong here because it would be hella nice to store it and not worry about loosing state). Approaching the issue from that angle I think the library should define what is a profile and then facilitate publishing the changes to the keys.

mikejr83 commented 6 years ago

FYI I'm going to break each one of those points out above into a "feature request"

sebirdman commented 6 years ago

yes, 100% on the profile stuff. It seems like it's entirely software based. Didn't know this at that time. I'll remove it.

AFAIK - we have cross platform support for linux and mac, has anyone tested windows?

With this PR: https://github.com/diefarbe/node-lib/pull/5 we've basically got full control over the packet.