search

diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

lfs_tags: fixed an error on currency formatting fallback #111

Closed xentry closed 11 years ago

xentry commented 11 years ago

On formatting error we have float "result" instead string -> as result lfs crashed on "result.strip()"

diefenbach commented 11 years ago

Hi Vlad,

but here we need a number:

https://github.com/xentry/django-lfs/blob/7921e711389aff56b8bbc669feb96330cecc45f2/lfs/core/templatetags/lfs_tags.py#L598

I'm not really sure why we need the call to strip at all. Can you check this out and replace the strip for instance?

Thanks Kai

diefenbach commented 11 years ago

Forget it, I think you are right!