diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

Change from django-tagging to django-taggit #112

Closed mthornhill closed 10 years ago

mthornhill commented 11 years ago

Code changes required to render django-taggit tags instead of django-tagging tags, also includes a management command to migrate django-tagging tags to django-taggit copied from https://github.com/kaleissin/django-taggit/commit/e3fe6f79bad444c4ad06bc530e80b3dab389131b

bin/django migrate_tagging_to_taggit

requirements django-taggit==0.10.0 django-taggit-templatetags==0.4.6dev django==1.4.6 (a requirement of django-taggit http://django-taggit.readthedocs.org/en/latest/)

mthornhill commented 11 years ago

The relevant changes for lfs_theme are in pull request https://github.com/diefenbach/lfs-theme/pull/16

pigletto commented 11 years ago

Can you please describe why to change django-tagging to django-taggit?

mthornhill commented 11 years ago

Hi Maciej, django-tagging doesn't support django 1.5 or greater. Thanks Michael

On Thu, Sep 5, 2013 at 7:43 AM, Maciej Wiśniowski notifications@github.comwrote:

Can you please describe why to change django-tagging to django-taggit?

— Reply to this email directly or view it on GitHubhttps://github.com/diefenbach/django-lfs/pull/112#issuecomment-23846781 .

p: +353 87 6124111 e: michael@maithu.com

diefenbach commented 10 years ago

Sorry for being late here, but I would rather remove tagging at all for now. AFAICS there is just small support for tagging within lfs.tagging. I'm going to provide lfs.tagging as a separate package.

IMO migration is not necessary because the only way to add tags to a product at the moment is via the description or the name of the same product. If an user decides to use another tagging solution he could simply recreate the existing tags.

mthornhill commented 10 years ago

Hi Kai, I'm happy with removing django-tagging altogether as the motiviation for the migration was to allow upgrade to later versions of django. Removing django-tagging achieves the same results with alot less effort. Thanks Michael