diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

Changing variable names #118

Closed emilian closed 11 years ago

emilian commented 11 years ago

Hi,

Is there any reason that the variable names keep changing? For example this commit:

https://github.com/diefenbach/django-lfs/commit/2e9762fd61fa5b335074762a97161f191c286d07

The change from "property" to "prop" seems to be without merit. Property is more descriptive, and allows you to know what is going on. What would happen if we started changing "category" to "cat", "value" to "val", "product" to "prod"? Answer: the code would become hard to read and understand.

Any thoughts?

pigletto commented 11 years ago

Hello

The point is that 'property' is python's builtin. That's why it shouldn't be used as variable name. Same applies to 'min', 'max' etc.

emilian commented 11 years ago

That makes sense :)

I was just worried variable names were changing without a reason. Closing the issue now.

pigletto commented 11 years ago

Thank you for your attention :)