search

diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

Any reason for the active_* fields on the product model? #125

Closed emilian closed 7 years ago

emilian commented 11 years ago

I cannot figure out why there is a need for the the active_ fields in the Product model.

If the product is a variant, and it defines a product name, then we should automatically use that name in place of the parent product's name. There is no need to "check" for an active field.

Thoughts? Or am I missing something?

diefenbach commented 11 years ago

Explicit is better than implicit.

Kai

Am 31.10.2013 um 12:31 schrieb Emilian Felecan notifications@github.com:

I cannot figure out why there is a need for the the active_ fields in the Product model.

If the product is a variant, and it defines a product name, then we should automatically use that name in place of the parent product's name. There is no need to "check" for an active field.

Thoughts? Or am I missing something?

— Reply to this email directly or view it on GitHub.

IQ++ Tel: +49 6182 / 774377-0 Fax: +49 6182 / 774377-1 Mail: kai.diefenbach@iqpp.de Web: http://www.iqpp.de Skype: kai.diefenbach

emilian commented 11 years ago

I generally agree with that, but in this case it seems like it is taken a bit too far. You have a whole lot of extra fields in the database, it complicates the forms, and seems clunky.