diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

Use GET with ajax-link #199

Closed pigletto closed 8 years ago

pigletto commented 8 years ago

Currently we're using links like:

<a class="ajax-link" href="{% url 'lfs_orders_inline' %}?page=1">

and these are being sent with POST. There are two issues:

  1. It doesn't work with server side construct like: page = (request.POST if request.method == 'POST' else request.GET).get("page", 1)

    that is used instead of request.REQUEST in older Django versions

  2. It is not consistent to use POST and send parameters with GET

My proposal is to just use $.get

diefenbach commented 8 years ago

Agreed! Please merge.