diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

Remove celery integration #200

Closed pigletto closed 8 years ago

pigletto commented 8 years ago

I'd like to remove celery integration from LFS in favour of using generic Django solutions for asynchronous emails like django-celery-email.

There is no need to have special code within LFS to support celery based emails. Also, current celery integration is broken. I just got

EncodeError Can't pickle <type 'uwsgi._Input'>: attribute lookup uwsgi._Input failed

after enabling celery for LFS yesterday. This error is possibly due to the fact that whole request objects is passed as a parameter to celery task in LFS.

The way we have current celery integration makes it impossible to use celery in the project without using LFS celery integration - LFS just checks if celery module is available.

Moreover, current LFS documentation for celery is outdated. Celery has changed a lot since these docs were written. Again, I see no point in maintaining these docs within LFS, unless in very simple way (as it's done in this pull request).

pigletto commented 8 years ago

Any thoughts on this?