search

diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

Feature/django 1.10 #205

Closed diefenbach closed 7 years ago

pigletto commented 7 years ago

  1. Pagination for Search page should be reimplemented with django's builtin pagination modules

  2. Possibly "STATIC_URL": context.get("STATIC_URL") lines should be removed from lfs_tags as it doesn't seem to be used and it relies on django.template.context_processors.static context processor that is not included in default settings from installation docs

  3. All occurences of {{ STATIC_URL }} in documentation should be replaced with {% static '...' %} for consistency with lfs-theme and because of lack of django.template.context_processors.static context processor within default settings from installation instructions

diefenbach commented 7 years ago

Good points. Will take care of them.

diefenbach commented 7 years ago
  1. Fixed.
diefenbach commented 7 years ago

2 + 3. Fixed

diefenbach commented 7 years ago

Please be aware that I resolved conflicts and forced pushed this branch.

pigletto commented 7 years ago

setup.py does not define specific version of Django as a requirement. Because of that Django 1.10 is installed as a dependency of django-localflavour which might cause issues as soon as next Django release appears

diefenbach commented 7 years ago

Fixed

pigletto commented 7 years ago

Using $.growl doesn't seem to work:

https://github.com/diefenbach/django-lfs/commit/931eaedaf57d2a822a14c2cfc2cd36947523de2d

pigletto commented 7 years ago

LGTM :)