Fix cart and customer updates on login

diefenbach / django-lfs

An online-shop based on Django

http://www.getlfs.com

BSD 3-Clause "New" or "Revised" License

622 stars 222 forks source link

Fix cart and customer updates on login #211

Closed pigletto closed 6 years ago

pigletto commented 6 years ago

When user logs in then his cart (created for Anonymous user) should be preserved and merged with authenticated user's cart (if any). It doesn't happen now as session_key used by update_cart_after_login is already a new key (due to a call to request.session.cycle_key() in auth->login). Tests for this behaviour are also invalid as these are not triggering default login view.

diefenbach commented 6 years ago

Has anything changed within Django?

pigletto commented 6 years ago

I haven't found much changes regarding cycle_key call on login since 1.8. Maybe there were some changes in previous versions. Anyway it doesn't work now