Rethinking the design decision on ordering custom address form fields?

[emilian]

Is there any specific reason that LFS chose "values_before_postal" and "values_after_postal" instead of a way to order the fields? For example, there could be a field attached to the class that orders the fields:

class MyAddress(BaseAddress): field_order = ("firstname", "lastname", "email", "mobile")

Also the "+" system seems a bit odd. All of that should be handled by a templatetag to display the form fields rather than doing it through the form definition.

What are your thoughts on these design decisions?

[diefenbach]

The ideas behind of that are:

1) postal address forms have different sets of fields in different orders. You can't order these fields and you don't want to, that's within the responsibility of postal. But you might position your own fields before and after the postal address.

2) This is just an easy way to provide some fields within one line e.g. first and last name. I agree that this could be removed completely and we just render all fields within one line. You are right, if one want something special one could just provide an own template. But it doesn't hurt and you can safely ignore it completely.

HTH Kai