search

diefenbach / django-lfs

An online-shop based on Django
http://www.getlfs.com
BSD 3-Clause "New" or "Revised" License
622 stars 222 forks source link

AttributeError Fix #62

Closed emilian closed 9 years ago

emilian commented 11 years ago

The method expects a product object, but receives a product slug which generates an AttributeError.

emilian commented 11 years ago

Added the template tag for generating the absolute URLs as well. Can you give me some feedback on these commits?

pigletto commented 11 years ago

Templatetag for generating absolute URLs seems to be interesting but it is not used in any place, so I don't really see a reason to have it in LFS code.

How did you manage to get the order without addresses set? Can you describe how to reproduce issue causing that Order object doesn't have addresses?

Two other commits (imports reorder and fix for attribute error) seems to be ok for me

emilian commented 11 years ago

The absolute URL is needed for canonical tags (something that should be in the templates). It is also needed for social sharing links (for example in the Facebook opengraph properties, Pinterest, Twitter etc.). Both of these features are a must have for product pages..and they all need absolute links to work.

I will have to think about how I reproduced the order without setting the addresses. I believe I was simply deleting the orders but will need to check.

Thanks for taking a look at these issues!