search

diefferson / http_certificate_pinning

Https Certificate pinning for Flutter
Apache License 2.0
83 stars 70 forks source link

Update dio constraints #36

Closed olexale closed 10 months ago

olexale commented 1 year ago

Sorry for bundling multiple things into a single PR. I hope it's tiny enough for the review, though.

With this PR, I propose to:

  1. Remove lock files from the repository, as they are not needed there. (locks files are in .gitignore in the Dart package template)
  2. Add the callFollowingErrorInterceptor flag to the dio interceptor. This allows users of this package to implement a single interceptor for error handling and deal with the error universally. This flag is false by default for backward compatibility.
  3. Most importantly, update dio constraints. Dio 5 introduced breaking changes, and not all projects have migrated to it. That broke backward compatibility for http_certificate_pinning for the 2.0.7 version. According to semver, that should have been a major release. As, again according to semver, dio 5.x.x should not have breaking changes in this version, I propose updating dio constraints and allowing using the old (4.0.6) and new (5.x.x) versions.
diefferson commented 10 months ago

Hi @olexale could you fix the conflicts?

knottx commented 10 months ago

Hi @olexale could you fix the conflicts?

i already added in #52

olexale commented 10 months ago

@diefferson, done