Verification of every request

diefferson / http_certificate_pinning

Https Certificate pinning for Flutter

Apache License 2.0

83 stars 70 forks source link

Verification of every request #39

Closed PawlikMichal25 closed 10 months ago

PawlikMichal25 commented 1 year ago

I'm very puzzled by this behaviour: https://github.com/diefferson/http_certificate_pinning/blob/master/lib/src/dio/certificate_pinning_interceptor.dart#L28

the whole point of SSL pinning is to have verification of every request, isn't it?

some references:

Dio official example also validating on every request https://github.com/cfug/dio/blob/c3f6fd70936df225e0c628659bf28c4661adf2f1/example/lib/certificate_pinning.dart#L29
https://stackoverflow.com/a/75131954

diefferson commented 10 months ago

Hi @PawlikMichal25, good point, this behavior was added by a contributor, I will analyze this code remove it or change this behavior to be optional and disabled as default.