search

diefferson / http_certificate_pinning

Https Certificate pinning for Flutter
Apache License 2.0
83 stars 70 forks source link

Pinning a certain certificate in the chain #46

Closed davideravasi closed 10 months ago

davideravasi commented 1 year ago

Hello, I am submitting a pull request to pin a specific certificate in the certificate chain. I decided to expand the original library in order to support the root/intermediate certificate pinning, which might be a use-case needed by some people/users (for example myself). Instead of just forking it for me and my team I think it would also be helpful if we can add it to the original library for the entire Flutter community. The main change is a new parameter in the check method called index. I defined it as a nullable Int in order to support the retro compatibility. The native implementation take it as 0 in case is not passed (as was doing before) in order to pin the leaf (same behaviour as before).

I'm not the best kotlin/swift dev out there so I am open to any suggestion to improve the codebase before having my PR approved.

alexbejann commented 10 months ago

@diefferson any plans for this PR?