search

dieggsy / esh-autosuggest

Fish-like autosuggestions in eshell.
GNU General Public License v3.0
103 stars 10 forks source link

Mimic Fish shell more #10

Closed ghost closed 5 years ago

ghost commented 5 years ago

The first commit adds an option to use a dedicated face for autosuggestion. The default company face for inline preview makes me always press RET to accept the suggestion due to my muscle memory. Because we are remapping company-active-map, I guess it might be a good idea to also remap faces. The default face is in a light gray color for less intrusive visual effects (similar to the default looking of Fish?).

The second commit fixes most warnings from the byte-compiler and checkdoc.

The third commit sets the company-minimum-prefix-length explicitly to match the instant suggestion behavior of Fish, similarly to what we did for company-idle-delay.

Thanks for this awesome package!

dieggsy commented 5 years ago

Thanks, for this, and sorry for taking so long to get back to you on the other PRs. I'll take a closer look and test the changes later tonight, but with regard to the faces, I'd rather inherit from the default company faces by default instead of hardcoding in arbitrary colors. This would make the default more consistent with whatever theme the user has chosen, but then they're still customizable to whatever the user wants.

ghost commented 5 years ago

If we are inheriting the default company faces then I think the customization variable for remapping faces is unnecessary? I added one more commit for this.

I was thinking to make the looking similar to Fish by default, but using company faces is also very reasonable to me.