search

dieggsy / eterm-256color

Customizable 256 colors for emacs term and ansi-term
GNU General Public License v3.0
69 stars 3 forks source link

Macos compat #2

Closed aaronjensen closed 6 years ago

aaronjensen commented 6 years ago

Fixes #1

dieggsy commented 6 years ago

So I added the commit to the readme - regarding the file check, I think I have a more robust solution. According to the manpage for tic (I also checked the manpage for osx and openbsd), it either looks in the dir specified by environment variable TERMINFO or ~/.terminfo. Because of this behavior, it may not make sense to make this a defcustom - we have all the options of where the file could be available to us.

It's possible (with f.el for example) to recursively check either TERMINFO if that is set or ~/.terminfo for the file eterm-256color, making the check more general and (ideally) system agnostic. Working on that now.

dieggsy commented 6 years ago

Oh, and thanks a lot for testing my package and opening this PR!

aaronjensen commented 6 years ago

That sounds like a much better solution. Thanks!