Several suggestions / mostly minor stuff

[jlacko]

Hello, I have a couple suggestions, based on my past mistakes:

• I suggest adding ubuntu 18 in Github Actions; it is notable for using PROJ version under 4.9.3, i.e. less than 6. This has saved me lot of trouble in the past, as PROJ 6.0.0 was a major change, with results not fully backward compatible. The SOLARIS build is a known troublemaker; this was the closest I got to being able to test the configuration it uses (it is rumored to have PROJ 5.2)
• I suggest unit testing for output format (data frame and sf) of the functions; not a problem now, but would serve as a kind of a straitjacket for if & when you decide to refactor the inner logic of your functions (there is some overlap in the API related code; this may be and may not be outsourced to an internal function to keep it in a single place)
• I suggest testing Pentagon to be positively polygon ("not point" could be satisfied with a line, geometry collection or one of the multi geometries; being specific about it being a polygon is safer)
• the name of the files (R and roxygenized Rd) documenting the package as a whole seems to be slightly dated (was the name "geocodinglite" already taken?)

Nothing really serious, treat is as a suggestion - and not hard critique :)

J.

[codecov[bot]]

Codecov Report

Merging #7 (2ac0205) into main (c4ffb5c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          494       494           
=========================================
  Hits           494       494           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4ffb5c...2ac0205. Read the comment docs.

[dieghernan]

LGTM, thanks @jlacko

Initially I named the package geocoderlite but when I started adding amenities and {sf} I switched. I noticed that long ago was a package on CRAN named nominatim (now here https://github.com/hrbrmstr/nominatim) but it seems to be abandoned (+3 years since last commit)