jlacko commented 3 years ago

As discussed in issue #8 I have prepared an update of polygon = TRUE to points_only = FALSE.

The change involved:

update of the *_sf functions (code + documentation)
update of the unit tests
update of vignette + readme file

As I am deeply in love with this functionality I took the liberty of adding one more example in the readme file (which is likely the first thing a prospective user of the package will see) - in addition to the Pentagon example I added a plot combining a river, a US state and a city as a point to illustrate the possibilities.

Please do have a look at the changes, as it was a lot of updates and a second set of eyes might catch something that has escaped me (all the unit tests & R CMD checks are passing, but still...)

codecov[bot] commented 3 years ago

Codecov Report

Merging #9 (c289df1) into main (9697c79) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          494       494           
=========================================
  Hits           494       494

Impacted Files	Coverage Δ
R/bbox_to_poly.R	`100.00% <100.00%> (ø)`
R/geo_address_lookup_sf.R	`100.00% <100.00%> (ø)`
R/geo_amenity_sf.R	`100.00% <100.00%> (ø)`
R/geo_lite_sf.R	`100.00% <100.00%> (ø)`
R/reverse_geo_lite_sf.R	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9697c79...c289df1. Read the comment docs.

dieghernan commented 3 years ago

Thanks

dieghernan / nominatimlite

polygon vs. points_only / relates #8 #9

Codecov Report