dieghernan / tidyterra

tidyverse and ggplot2 methods for terra spatial objects
https://dieghernan.github.io/tidyterra/
Other
168 stars 7 forks source link

Test broken with upcoming ggplot2 #129

Closed teunbrand closed 8 months ago

teunbrand commented 8 months ago

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break tidyterra.

The gist of the breakage is that we've added layout in a different way to plots that breaks a plot equality test in tidyterra. In this PR, we remove the layouts before testing for equality.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. We hope that this PR might help tidyterra get out a fix if necessary.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d011f4d) 99.57% compared to head (deb87c9) 99.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #129 +/- ## ======================================= Coverage 99.57% 99.57% ======================================= Files 44 44 Lines 2575 2575 ======================================= Hits 2564 2564 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dieghernan commented 8 months ago

Thanks for the PR, I would try to send a new release to CRAN early next week.

teunbrand commented 8 months ago

Thanks for the prompt response!

dieghernan commented 8 months ago

Just to confirm, running on my machine

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))
devtools::check(cran = TRUE, manual = TRUE)

gives

── R CMD check results ─────────────────────────── tidyterra 0.5.1.9000 ────
Duration: 13m 9.2s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔
teunbrand commented 8 months ago

Good, that soothes the soul :)

dieghernan commented 8 months ago

HI @teunbrand

tidyterra 0.5.2 is already on CRAN, I checked once again and no hiccups:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))
devtools::check(cran = TRUE, manual = TRUE)
teunbrand commented 8 months ago

Awesome, that is quick!