search

diego-urgell / BinSeg

GSOC 2021. R package that performs changepoint analysis using the Binary Segmentation algorithm. Supports several statistical distributions. The model is computed in C++ and then interfaced with R via the Rcpp package.
https://summerofcode.withgoogle.com/projects/5915303348797440
MIT License
4 stars 0 forks source link

class names consistent with changepoint package #5

Closed tdhock closed 3 years ago

tdhock commented 3 years ago

to avoid any confusion I think it would be helpful to use the same names for our distribution classes as in https://github.com/rkillick/changepoint/blob/master/src/cost_general_functions.c @diego-urgell that would mean for example using mean_norm instead of MeanNorm -- does that make sense to you?

diego-urgell commented 3 years ago

Most of the times I use to name my classes and functions using camelCase, but I realize that in this case it is better to use a notation that is more consistent with the existing R changepoint analysis packages.

tdhock commented 3 years ago

great