Pending GameKit/Lua Improvement Questions

[GoogleCodeExporter]

I have asked some questions in regards to the scripting side of GameKit on the 
official forums that haven't been picked up by the developers. I'm hoping to 
grab their attention here.

gsGameObject::clone - Objections? (now really "gsScene::cloneObject - 
Objections?")
http://www.gamekit.org/forum/viewtopic.php?f=9&t=190

Duplicate gsObject userdatas
http://www.gamekit.org/forum/viewtopic.php?f=9&t=191

They were both initially questions on whether certain features "should" be 
implemented, but as I found myself requiring/desiring them done anyway - I have 
made the changes locally and would like to know whether the main devs  want 
them for the official source repo.

Sorry, but without nagging the developers individually, I wasn't sure the best 
way to grab their attention.

Original issue reported on code.google.com by BenT.Sol...@gmail.com on 4 Aug 2011 at 1:35

[GoogleCodeExporter]

It seems useful for Lua script.
Please, submit patches, I will review your patch and commit to trunk.

Original comment by harkon...@gmail.com on 7 Aug 2011 at 2:54

• Changed state: Accepted

[GoogleCodeExporter]

The cloneObject change is simple (though the diff is large due to my updated 
version of SWIG). I've attached it below. The diff includes a simple test of 
the function in the AppLuaRuntime application.

Original comment by BenT.Sol...@gmail.com on 7 Aug 2011 at 11:34

Attachments:

• cloneobject.diff

[GoogleCodeExporter]

I was hoping that there could be some discussion on the second patch before 
submitting it. There is a major change in the way objects get passed into the 
Lua side of the equation with a resultant large change in the codebase 
(limited, of course, to the Script directory/files).

Given the code changes result in different objects being returned from the 
gs<Class> wrappers, I also need some info on how to get the Lua document 
building working again.

Original comment by BenT.Sol...@gmail.com on 7 Aug 2011 at 11:45

[GoogleCodeExporter]

CloneObject patch is applied to trunk.
Thanks.

Original comment by harkon...@gmail.com on 8 Aug 2011 at 3:22

[GoogleCodeExporter]

Thanks for that harkon. It was a very basic change, but I think useful.

Is there anyone with the requisite knowledge to understand the details I've 
posted on the forum? I'd like to make a finished patch for the memory saving 
changes to the scripting layer as well, but I hate to leave things unfinished.

http://www.gamekit.org/forum/viewtopic.php?f=9&t=191

Original comment by BenT.Sol...@gmail.com on 9 Aug 2011 at 12:57

[GoogleCodeExporter]

OK, the diff on the scripting change is huge due to (in part) the large changes 
to the processed SWIG file. It is however, limited to only the scripting files 
except for the strange case where garbage collecting a logic object in script 
needs to remove it from the scene (this does not happen for anything else, but 
I wanted to have no change in functionality).

Looking forward to feedback on the matter

Original comment by BenT.Sol...@gmail.com on 22 Aug 2011 at 11:44

Attachments:

• scripting-diff.diff