diego3g / electron-typescript-react

:electron: An Electron boilerplate including TypeScript, React, Jest and ESLint.

1.45k stars 295 forks source link

Improve the Button component #14

Closed tkeiyama closed 4 years ago

tkeiyama commented 4 years ago

Hi, there! These commits are small issues, but I wanna create this PR.

Summary

Removed an unused import statement
Added a case to test the button attribute

Details

Removed an unused import statement The import statement of the Container component is currently commented out. If you are working on it, this change isn't needed.
Added a case to test the button attribute I wanted to test that the Button component is rendered correctly. So I added the @testing-library/jest-dom library, then test that it has a 'button' type. This may be over-testing. If you don't need this, I'll remove this.

Anything else

Nothing.

tkeiyama commented 4 years ago

@diego3g Thank you for the comment. I created the tests folder and the setupTests.ts file, then I moved the extend to that file.

Please tell me if you have any other ideas of a folder name, a path of a global setup file, or something else.

diego3g commented 4 years ago

@thomasJs8 Actually i think it's great for now. Thanks for the PR.