diego3g / faladev

Meu site pessoal onde deixo todas minhas configurações atuais como do Visual Studio Code, Fish e informações sobre meu setup.
https://fala.dev
251 stars 41 forks source link

feat: add tabs #10

Closed Majortheus closed 1 year ago

Majortheus commented 1 year ago

Based on this video where @diego3g suggests to make this site close to a real visual code, and one of the suggestions is to have tabs, so tried to have a look on what i could come up with, and this is the result

Preview: preview

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
fala-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 3:43PM (UTC)
diego3g commented 1 year ago

First of all, WTF, this is awesome. I'll take a look at it in a couple of days and add my comments here. Thanks!

Majortheus commented 1 year ago

Did some changes, most to make the code more close to the suggestions proposed, there are probably more stuff to fix, and I'm happy to do it.

Looking forward for the new review, this is my first public PR, and it's been reviewed by the person I think I learned the most about coding and JS, very glad a I'm able to amaze you and learn a lot, specially about Next.js 13. 😄

pedro-santos-sky commented 1 year ago

Amazing job, congrats @Majortheus 👏 👏 !!!

diego3g commented 1 year ago

Hello @Majortheus, great job!

I'm having some issues while trying to open more than one file, can you take a look at it?

https://user-images.githubusercontent.com/2254731/220647008-b74ad647-1bd1-4874-a6f6-273895a297cd.mp4

Majortheus commented 1 year ago

I tested with Vercel preview link and yep that's happening, but I remember testing before doing the last commit, so I tested in my machine and... it's working as intended... how fun aheuaheu, I will take a closer look, if you have any pointers, pls gimme it, I already tried to use pnpm build and pnpm start instead of dev, but it didn't make any changes, I don't have any idea on why that's happening though.

https://user-images.githubusercontent.com/31166233/220658995-60880316-794b-4ee6-9bd3-f518ea1ff7ff.mp4

Majortheus commented 1 year ago

Hmmm I don't know what to do anymore, I tried to undo all the changes before this bug, if you look the deploy before the changes I did today, it was working normal, but the first deploy after it started happening, so I undo all changes and it's happening still, I have no clue...

image This deploy is working https://fala-5b58z0knk-rocketseat.vercel.app/

Any deploy afterwards it's not, I will take a break, to reset, I will try again later.

RaczoOBY commented 1 year ago

I've been looking at some other PRs, and every single new PR has a curious behavior atfer 21/02. Even if we check out the commit "fix names and auto formatting" and redeploy it, the from next/link is causing hard reloads.

diego3g commented 1 year ago

@Majortheus @RaczoOBY probably some problem with Vercel? 🤔

diego3g commented 1 year ago

I tested it on my local environment and it works properly. I think there ir something wrong with preview deployments on Vercel so I will merge this.