diegoazh / gmap-vue

A wrapper component for consuming Google Maps API built on top of Vue. Fork of the popular vue-google-maps plugin.
https://diegoazh.github.io/gmap-vue/
172 stars 50 forks source link

Feature: Add the title prop to GmapCluster #177

Closed mcadecio closed 2 years ago

mcadecio commented 3 years ago

Is your feature request related to a problem? Please describe. At the moment, when a user hovers on a cluster, a tootle tip does not show. The title is present in the element but there is no way to set a value through the component. (a prop has not been specified in the cluster.js file)

Describe the solution you'd like I would like to be able to set the title for a gmap cluster through a prop value.

The solution is quite simple:

Add the following to the props variable in cluster.js:

 title: {
    type: String,
    twoWay: false      // we don't need a listener on the title
  }

Describe alternatives you've considered Not need, simple request.

Additional context No additional context.

boring-cyborg[bot] commented 3 years ago

Thanks for opening your first issue here! Be sure to follow the issue template!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

diegoazh commented 2 years ago

Hi, @mcadecio can you test the new version 2.0.0 and let me know if is possible if not I will land this change on the next version.

create-issue-branch[bot] commented 2 years ago

Branch issue-177-Feature_Add_the_title_prop_to_GmapCluster created!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

diegoazh commented 2 years ago

On the new library that we use for clusters, I couldn't find any option to set a title on the cluster icon, I let you the link here if you find the way to set the title please let me know or, also, you can make a PR, contributions are welcomed; until having an answer for you I'll maintain this issue closed. Thank you and regards.

Link to Google Maps documentation