diegoazh / gmap-vue

A wrapper component for consuming Google Maps API built on top of Vue. Fork of the popular vue-google-maps plugin.
https://diegoazh.github.io/gmap-vue/
173 stars 51 forks source link

Bug: CirclePromise missing from Circle Shape. #306

Closed AlexJezior closed 6 months ago

AlexJezior commented 1 year ago

Describe the bug

Having a problem when rendering a CircleShape in the map component. After the circle shape has rendered, we fit bounds of the map based on the circle shape's bounds returned.

In the previous version of this package, we had a ref on the circle shape component, and when mounted we would leverage the $circlePromise of the component to let us know when it's ready so that we can adjust the map bounds.

To reproduce

Steps to reproduce the behavior:

  1. Import and use GmvMap, and the GmvCircle.
  2. In vue dev tools, inspecting the rendered references, and only a circleShapeInstance property is available, and it's undefined.

Expected behavior

In vue dev tools, we should have access to the $circlePromise on the circle ref.

Current behavior

No $circlePromise available on the CircleShape.

Screenshots

image

Desktop (please complete the following information)

Smartphone (please complete the following information)

Additional context

Add any other context about the problem here.

Versions

Package manager

Plugin version

create-issue-branch[bot] commented 11 months ago

Branch issue-306-Bug_CirclePromise_missing_from_Circle_Shape created!

diegoazh commented 7 months ago

Hello @AlexJezior, could you test our new version v2.0.0? also, you can find the main points on our new documentation site.

diegoazh commented 7 months ago

Fixed on v2.0.0, now you have the circleShapePromise exposed from the plugin again.

diegoazh commented 6 months ago

I'm closing this issue because was fixed on v2.0.0, now the circle promise is exposed. Feel free to re-open it if it's needed.