search

diegobenincasa / quick-geocoder

QGIS 3 plugin for forward/reverse geocoding using many different services and GeoPy
0 stars 0 forks source link

Bing key? #4

Open pcav opened 4 years ago

pcav commented 4 years ago

apparently you added a valid Bing key in public repo

diegobenincasa commented 4 years ago

Have I?

I will check this. But the code stores the key in a QgsSettings() variable, so it wouldn't be given with the plugin.

I might have forgot to remove a commented line with a key. If that's the case, I'll fix it.

On Thu, Dec 19, 2019, 12:08 Paolo Cavallini notifications@github.com wrote:

apparently you added a valid Bing key in public repo

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/diegobenincasa/bing-geocoder/issues/4?email_source=notifications&email_token=ADDLR5AD4VVRTCAD623R4CTQZOE6NA5CNFSM4J5IRNZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IBVM5UA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLR5CXBZCK3MM4RWVTFMTQZOE6NANCNFSM4J5IRNZA .

diegobenincasa commented 4 years ago

In fact, I have provided the key with the code. It's a line of code I"be used during tests and forgot to remove. Thanks for spotting that!

On Thu, Dec 19, 2019, 14:10 Diego Benincasa diego@diegobenincasa.com wrote:

Have I?

I will check this. But the code stores the key in a QgsSettings() variable, so it wouldn't be given with the plugin.

I might have forgot to remove a commented line with a key. If that's the case, I'll fix it.

On Thu, Dec 19, 2019, 12:08 Paolo Cavallini notifications@github.com wrote:

apparently you added a valid Bing key in public repo

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/diegobenincasa/bing-geocoder/issues/4?email_source=notifications&email_token=ADDLR5AD4VVRTCAD623R4CTQZOE6NA5CNFSM4J5IRNZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IBVM5UA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLR5CXBZCK3MM4RWVTFMTQZOE6NANCNFSM4J5IRNZA .