diegoborbadev / pytube-downloader

📺 Web app for downloading video or audio from YouTube!
https://pytube.diegoborba.dev
MIT License
3 stars 1 forks source link

Frontend Overhaul #26

Closed codeIntrovert closed 9 months ago

codeIntrovert commented 9 months ago

Pull Request: Frontend Overhaul

Description

This pull request addresses and closes issues #24 and #25 by completely rebuilding every aspect of the frontend. The entire frontend is now built on Python-Flask, providing a more robust and efficient user interface. Extensive testing has been conducted on various devices, including phones, desktops, and displays of varying sizes.

Changes Made

Testing

Effort Invested

I have invested significant time and effort into rebuilding the frontend to enhance the overall user experience and address the reported issues.

Related Issues

Screenshots

image

Checklist

diegoborbadev commented 9 months ago

Can you change the color palette to red shades?

codeIntrovert commented 9 months ago

Sure I will!

codeIntrovert commented 9 months ago

image

Done

diegoborbadev commented 9 months ago

Awesome! I'll review it as soon as possible.

diegoborbadev commented 9 months ago

Congratulations on the good work! However, there are some adjustments that should be made:

Remove the .old files

The .old files are not needed anymore, they can be viewed in the history of the repository.

Footer improvements

Remove "by" statements

Remove "created by Diego Borba" and "UI Design by Hasan" statements.

Reduce footer size

The footer is too big, it should be reduced.

Check click-scroll TypeError

When scrolling, the following error is displayed in the console:

image

Add a loading indicator

Some downloads can be very slow, so a loading indicator is needed.

Fix header logo link

When you click on the header logo, it redirects to /index.html, but it throws a 404 error.

codeIntrovert commented 9 months ago

✅ Fixed Click Scroll

✅ Reduced Footer Size

✅ Added loading indicator

✅ Removed .old files

❗ Kept Footer Links for proper attribution of Open Source Creator

✅ Fixed header link

diegoborbadev commented 9 months ago

This is Important to respect contributor's time & effort

I agree, but as the number of contributors increases, it will become impractical to list everyone's names on the interface.

codeIntrovert commented 9 months ago

Removed Contributer name list