search

diegocasmo / iis-project

0 stars 0 forks source link

Final notebook #13

Closed diegocasmo closed 6 years ago

tristaaan commented 6 years ago

(Added hyphen to the title of this PR because it kept insinuating something.)

diegocasmo commented 6 years ago
diegocasmo commented 6 years ago

@tristaaan @ankurshukla03

Any comments/requested changes from this? Otherwise approve such that it can be merged and work on it continued (need to fill-in TODOs, see #19)

diegocasmo commented 6 years ago

@ankurshukla03 please do not make changes to the notebook just yet, let's merge it first and work on local branches instead

tristaaan commented 6 years ago

Reverted and working in different files, we can even move this to a new branch

On Wed, May 23, 2018 at 11:32 Diego Castillo notifications@github.com wrote:

@ankurshukla03 https://github.com/ankurshukla03 please do not make changes to the notebook just yet, let's merged first and work on local branches instead

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/diegocasmo/iis-project/pull/13#issuecomment-391284072, or mute the thread https://github.com/notifications/unsubscribe-auth/AFN5m00hllWt4vGWQ-DBWUQBA6--wkfwks5t1Sy0gaJpZM4UG8Bh .

-- -Tristan Wright

tristaaan commented 6 years ago

What happened to the files in this commit?

tristaaan commented 6 years ago

Found it, it is now just code/solution.ipynb I guess I'm too on edge when I find certain files in a git repo have disappeared.

ankurshukla03 commented 6 years ago

In code directory, solution.ipynb is the notebook which we will use for video recording. There is no folder name final in master branch now.

ankurshukla03 commented 6 years ago

The way i have made some commits disappeared it seems fine if you worry about it.

I guess I'm too on edge when I find certain files in a git repo have disappeared.