Closed diegoceccarelli closed 6 years ago
@tgalery I spent some time this morning trying to configure (unsuccessfully) an instance of jenkins, and then I tried travis-ci. I'm very happy with it, automatically tests the pull requests, provides test coverage, and email notifications. This PR for me is good to be merged. What do you think?
Looks good to me, I guess the warning No coverage uploaded for pull request base
means that once this hits master, the base branch would have coverage data and future warnings would disappear. I took a look at the pr branch and the ci badge says that the build status is unknown. Is this supposed to be like this ?
Also, squashing this to one commit might be the way to go.
Thanks @tgalery Build status is unknown because it's the status of the master (I had to hardcode the branch in the markdown) and the master still has to run travis. I think (hope) it will run it after the merge
Codecov Report
Continue to review full report at Codecov.