diegoceccarelli / json-wikipedia

Json Wikipedia, contains code to convert the Wikipedia xml dump into a json/avro dump
Apache License 2.0
252 stars 42 forks source link

Add travis-ci yml configuration #30

Closed diegoceccarelli closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@537a3d6). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   43.14%           
=========================================
  Files             ?       22           
  Lines             ?     1050           
  Branches          ?      214           
=========================================
  Hits              ?      453           
  Misses            ?      556           
  Partials          ?       41

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 537a3d6...d77f067. Read the comment docs.

diegoceccarelli commented 6 years ago

@tgalery I spent some time this morning trying to configure (unsuccessfully) an instance of jenkins, and then I tried travis-ci. I'm very happy with it, automatically tests the pull requests, provides test coverage, and email notifications. This PR for me is good to be merged. What do you think?

tgalery commented 6 years ago

Looks good to me, I guess the warning No coverage uploaded for pull request base means that once this hits master, the base branch would have coverage data and future warnings would disappear. I took a look at the pr branch and the ci badge says that the build status is unknown. Is this supposed to be like this ? Also, squashing this to one commit might be the way to go.

diegoceccarelli commented 6 years ago

Thanks @tgalery Build status is unknown because it's the status of the master (I had to hardcode the branch in the markdown) and the master still has to run travis. I think (hope) it will run it after the merge