diegoceccarelli / json-wikipedia

Json Wikipedia, contains code to convert the Wikipedia xml dump into a json/avro dump
Apache License 2.0
252 stars 42 forks source link

Create jar with dependency using `maven-shade-plugin` instead of assembly #45

Closed diegoceccarelli closed 3 years ago

diegoceccarelli commented 4 years ago

At the moment we use the goal assebly:assembly to produce a jar with all the dependency.

maven-shade-plugin is better than assembly http://2mohitarora.blogspot.com/2011/12/maven-shade-plugin-better-than-maven.html and it will produce that jar when running the normal maven target package.

Also set it up so that the main can be run from the jar. Example here: http://maven.apache.org/plugins/maven-shade-plugin/examples/executable-jar.html

sparrowV commented 4 years ago

@diegoceccarelli can u assign this to me?

diegoceccarelli commented 4 years ago

@sparrowV done, thanks!