search

diegocr / CleanLinks

Converts obfuscated/nested links to genuine clean links.
166 stars 45 forks source link

Firefox on Android does not show Cleanlinks toolbar button #117

Open w8sdz opened 8 years ago

w8sdz commented 8 years ago

How do I turn Cleanlinks on and off on Firefox for Android 6.01? There does not seem to be a toolbar for buttons. I believe it is turned off because it does not clean any links.

jawz101 commented 8 years ago

I'm fine with it as is but there isn't an interface for Link Tracking. Plus, you can't click on any of the Learn More links in the settings screen.

Oh. To look at the add-ons settings go to tools, add-ons and click on the add-on.

You can test if it's working by going to m.facebook.com. If you can't log in it's doing something. I always have to whitelist that url.

w8sdz commented 8 years ago

The extension is not working in Firefox 46.0.1 for Android. I tried your test on m.facebook.com and was able to log in.

jawz101 commented 8 years ago

... Ok. I guess the only way I know it's doing "something" is because I have Use HTTP Observer checked and that's when it won't let me log in (I also check the Use Redirect Watcher and Follow Target Attribute settings.)... And also when clicked links turn yellow because of Event Delegation Mode set.

Note the bold in the excerpt from the Add-on page below about the clicking links. I don't know how you're checking if it's working but the function in the desktop version where it checks all the links on a page when it's loaded - and before you click on anything- won't show all of the yellow blocks everywhere. Only when you click on stuff will it actually clean the links and show yellow indicators. It's a little more passive in that regard which just means it isn't checking all of the links prior to you actually clicking the links. If you have event delegation mode unchecked on the desktop version, for example, I assume it's showing yellow highlights everywhere. It won't in the mobile version unless a cleaned link is clicked (I think that's how it works).

From what I've read the Mobile version won't even work without Event Delegation Mode checked. https://addons.mozilla.org/en-US/firefox/addon/clean-links/

The Add-On has two working modes:

DOM Traversing: When a website is loaded its DOM is scanned and any suitable link is cleaned. On this mode when some links are cleared the toolbar button will change and you'll be able to mouse-over it to open its popup where you can see the number of fixed links on the current website.

Delegation: This is a less intrusive mode by just listening to click events. Note that unlike for DOM traversing real-time highlighting and counters will not work then, even though the performance should be much better.

DOM Traversing was the default mode prior to version 2.4, on later versions Event Delegation mode is set as default, and under Firefox for Android and Thunderbird it shouldn't be changed.

untitled